[Draft] TypeSpec Migration Validation#9497
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @FumingZhang, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @FumingZhang Release SuggestionsModule: aks-preview
Notes
|
There was a problem hiding this comment.
Pull request overview
This PR performs a TypeSpec migration validation for the aks-preview Azure CLI extension. The changes primarily involve updating auto-generated SDK code to align with TypeSpec specifications, including standardization of long-running operations (LRO), removal of duplicate documentation, header casing corrections, and pagination fixes.
Key changes:
- Standardized LRO polling configuration with explicit
lro_optionsfor final-state tracking - Removed duplicate docstring descriptions across multiple operations
- Fixed pagination to properly return
next_linkinstead ofNone - Normalized HTTP header casing to lowercase (e.g.,
if-match,if-none-match)
Reviewed changes
Copilot reviewed 45 out of 52 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
_trusted_access_roles_operations.py |
Removed duplicate docstring |
_trusted_access_role_bindings_operations.py |
Removed duplicate docstrings, added response headers for LRO, updated polling configuration |
_snapshots_operations.py |
Removed duplicate docstrings across all operations |
_resolve_private_link_service_id_operations.py |
Removed duplicate docstrings |
_private_endpoint_connections_operations.py |
Removed duplicate docstrings, added 202 status code handling, added response headers, updated polling |
_operations.py |
Fixed pagination next_link handling |
_operation_status_result_operations.py |
Swapped function order and URL paths for get and get_by_agent_pool |
_mesh_memberships_operations.py |
Removed duplicate docstrings, added response headers, updated polling configuration |
_managed_namespaces_operations.py |
Removed duplicate docstrings, swapped build functions, updated response headers, updated polling, moved delete function |
_managed_clusters_operations.py |
Extensive reordering of methods, header casing changes, response header additions, polling updates, URL path fixes |
_managed_cluster_snapshots_operations.py |
Removed duplicate docstrings |
_maintenance_configurations_operations.py |
Removed duplicate docstrings |
_machines_operations.py |
Header casing changes, removed duplicate docstrings, conditional response headers, updated polling |
_load_balancers_operations.py |
Removed duplicate docstrings, reordered response headers, updated polling |
_jwt_authenticators_operations.py |
Removed duplicate docstrings, conditional response headers, updated polling |
_identity_bindings_operations.py |
Removed duplicate docstrings, reordered response headers, updated polling |
__init__.py (operations) |
Reordered imports alphabetically |
_container_service_client_enums.py |
Updated enum documentation and reordered values |
__init__.py (models) |
Removed SubResource export |
aio/operations/*.py |
Async versions of above changes |
FumingZhang
force-pushed
the
fuming/typespec-migration-t2
branch
from
ec6287a to
be44893
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
[Draft] TypeSpec Migration Validation
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.